Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added board definition for upcoming 2MB variant of the Pimoroni Tiny 2040 #5684

Merged
merged 3 commits into from
Dec 8, 2021

Conversation

ZodiusInfuser
Copy link

Also, updated the display name of the current Tiny 2040 to clarify it is 8MB.

@ZodiusInfuser
Copy link
Author

Raised PR for the website too: adafruit/circuitpython-org#808

@tannewt tannewt added board New board or update to a single board rp2040 Raspberry Pi RP2040 labels Dec 8, 2021
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! If both the 8mb and 2mb are winbond chips, the builds may work across versions because the rp2 port detects the flash size.

@tannewt tannewt merged commit 8eee16c into adafruit:main Dec 8, 2021
@ZodiusInfuser
Copy link
Author

Thanks Scott! They are both Winbond chips, but the codes are different so I thought that meant they were incompatible so went for a separate entry. 2MB has the code W25Q16JVxQ (same as the Pi Pico) whereas the 8MB has W25Q64JVxQ. Should the designation be changed to something like W25QxJVxQ going forward?

@tannewt
Copy link
Member

tannewt commented Dec 8, 2021

I think a separate entry will still be clearer.

We'll want to keep the designation the same because some ports do need the size. Instead, EXTERNAL_FLASH_DEVICES can be a comma separated list of flashes and the stage2 script should determine a compatible config for both. See https://github.com/adafruit/circuitpython/blob/main/ports/raspberrypi/boards/arduino_nano_rp2040_connect/mpconfigboard.mk#L10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board New board or update to a single board rp2040 Raspberry Pi RP2040
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants