Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore BLEIO HCI background task #5683

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Dec 8, 2021

Fixes #5462.

BLEIO HCI uses a background task to monitor communications with the co-processor. The background task was inadvertently deleted when the BLE workflow code was added and merged.

Also renamed the background routine to be clearer it is HCI only.

@dhalbert dhalbert requested review from tannewt and jepler December 8, 2021 03:45
@dhalbert dhalbert linked an issue Dec 8, 2021 that may be closed by this pull request
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that! I didn't think bleio needed it because the ble interrupt queued a background task for it.

@tannewt tannewt merged commit bf08f62 into adafruit:7.1.x Dec 8, 2021
@dhalbert dhalbert deleted the restore-bleio-hci-background branch December 8, 2021 18:32
@dhalbert
Copy link
Collaborator Author

dhalbert commented Dec 8, 2021

I didn't think bleio needed it because the ble interrupt queued a background task for it.

There may be a more "on-demand" way to do it, but I didn't look at that right now. There can be bytes coming from the HCI interface at any time, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLE HCI is not connecting on CP 7.0.0
2 participants