Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a frequencyin_reset() for VM restart #5665

Merged
merged 4 commits into from
Dec 7, 2021

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Dec 5, 2021

Fixes #5643.

FrequencyIn was assuming it was started cleanly. But in the case of a VM restart (e.g. soft boot), some resetting needed to be done.

@dhalbert dhalbert marked this pull request as draft December 5, 2021 19:54
@dhalbert
Copy link
Collaborator Author

dhalbert commented Dec 5, 2021

Hmm, non-debug version does not work... Continuing on this.

@tannewt tannewt added this to the 7.1.0 milestone Dec 6, 2021
@dhalbert
Copy link
Collaborator Author

dhalbert commented Dec 7, 2021

The logic for SAMx5 boards without crystals was not complete, and the setting logic was mixed up a bit with the crystal case. Redid reference oscillator setup. Tested on Metro M4 (has crystal) and ItsyBitsy M4 (no crystal).

@dhalbert dhalbert marked this pull request as ready for review December 7, 2021 03:43
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@tannewt tannewt merged commit 5740393 into adafruit:7.1.x Dec 7, 2021
@dhalbert dhalbert deleted the frequencyio-fix branch December 7, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants