Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable -Wmissing-prototypes for atmel-samd #5561

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

jepler
Copy link
Member

@jepler jepler commented Nov 10, 2021

When a function is defined, but its declaration isn't present, the compiler can't check that the declaration and definition match. "-Wmissing-prototypes" enables a diagnostic in this case.

Fixes fall into several categories:

  • Include headers where needed
  • Add/fix declarations / definitions where needed
  • Mark functions as static if appropriate
  • Remove some never-used functions

This PR aims to fix all the diagnostics that occur in the atmel-samd builds, so that the -Wmissing-prototypes flag can be enabled in that whole port.

@jepler jepler marked this pull request as ready for review November 10, 2021 03:14
@jepler
Copy link
Member Author

jepler commented Nov 10, 2021

The build error on pyruler was a transient Actions problem, it built locally.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me; thanks for fixing all the little things.

@dhalbert dhalbert merged commit 4a1ce64 into adafruit:main Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants