Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account for deleted boards #5518

Merged
merged 1 commit into from
Oct 26, 2021
Merged

account for deleted boards #5518

merged 1 commit into from
Oct 26, 2021

Conversation

jepler
Copy link
Member

@jepler jepler commented Oct 26, 2021

Over in #5516 there was a build error about the removed board:

Adding docs/boards to build based on changed files
Building docs: False
Building boards:
Traceback (most recent call last):
  File "ci_set_matrix.py", line 131, in <module>
    main()
  adafruit_feather_esp32s2
  File "ci_set_matrix.py", line 127, in main
  adafruit_feather_esp32s2_nopsram
    set_boards_to_build(build_all)
  File "ci_set_matrix.py", line 91, in set_boards_to_build
    arch = PORT_TO_ARCH[board_to_port[board]]
KeyError: 'adafruit_feather_esp32s2_nopsram'

deleted files cause the related code to build (this is sensible! don't change it) but if what's deleted is a whole board you get an error like that.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@dhalbert dhalbert merged commit a8b69f2 into adafruit:main Oct 26, 2021
@tannewt
Copy link
Member

tannewt commented Oct 28, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants