Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _bleio.start_advertising arg check; add doc to SocketPool.socket() #5508

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Oct 25, 2021

Changes:

  • Improve documentation noting that SocketPool.socket() does not take all the arguments that CPython socket.socket() takes.
  • Fix arg checking for Adapter.start_advertising(..., directed_to=...).
  • Implement passing directed_to arg via HCI in BLE HCI device support. Not tested.

@Neradoc I tested the start_advertising() fix in the REPL, but if you could try too, that would be great.

@Neradoc
Copy link

Neradoc commented Oct 25, 2021

Works, thanks !
Tested on the Circuitplayground Bluefruit with the code with which I discovered the issue.

Copy link
Collaborator

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel competent to review this. Given @Neradoc successful test it looks good.

@ThomasAtBBTF
Copy link

"Implement passing directed_to arg via HCI in BLE HCI device support. Not tested."

Does this mean, that I can find the address of a host somewhere in BLE HCI?

@dhalbert
Copy link
Collaborator Author

"Implement passing directed_to arg via HCI in BLE HCI device support. Not tested."

Does this mean, that I can find the address of a host somewhere in BLE HCI?

No, sorry, I did not add that, so this support is latent.

@ThomasAtBBTF
Copy link

@dhalbert that's ok.
Don't hurry!
You anyway move so much ....

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@tannewt tannewt merged commit e049db7 into adafruit:main Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

additional positional arguments failure in requests directed_to may not allow None anymore
5 participants