Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hash() for Event #5486

Merged
merged 1 commit into from
Oct 20, 2021
Merged

fix hash() for Event #5486

merged 1 commit into from
Oct 20, 2021

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Oct 19, 2021 •
edited
Loading

This was kind of an amusing error. C lets you reference a declaration in itself. That happened inadvertently.
E.g.,

void *x = &x;

Happy to have anyone review.

@dhalbert dhalbert requested a review from jepler October 19, 2021 23:11
jepler
jepler approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An excellent bug with an excellent fix. I know it's technically valid C but I'm still surprised there's not a diagnostic when it occurs!

@dhalbert dhalbert merged commit 28a58c3 into adafruit:main Oct 20, 2021
@dhalbert dhalbert deleted the keypad-event-hash branch October 20, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keypad.Event hash() is always the same
2 participants
@dhalbert @jepler