PicoSystem: Add DisplayIO to board config #5398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @deshipu pretty sure we dont want to use gamepad or gamepad shift anymore, replaced with keypad https://learn.adafruit.com/key-pad-matrix-scanning-in-circuitpython |
|
I think "gamepad" is used by ugame- but I'm not quite sure how this all hangs together and what the dependencies are. It looks like "gamepad shift" is not needed though, as it deals with shift-register based inputs which PicoSystem doesn't have! I'll rebase that out. |
|
I think stage was already switched to keypad: python-ugame/circuitpython-stage@a895b3a |
* Bring up PicoSystem's display with DisplayIO * Add stage game library * Add supporting modules - AUDIOIO and KEYPAD
6612e2d to
2fc6a72
Compare
deshipu
approved these changes
Oct 1, 2021
|
@Gadgetoid Don't forget to mark this as ready when it is. |
I had checked in a couple of times and completely failed to notice it was still in draft form, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds DisplayIO bringup to the Pimoroni PicoSystem.
This is raised as a draft with a line in mpconfigboard stubbed out (so checks will hopefully pass), pending the addition of a PicoSystem "stage" and "ugame" to https://github.com/python-ugame/circuitpython-stage/ and a bump to the submodule.
Looks like circuitpython-stage submodule is currently tracking master, so there shouldn't be any implications in bumping it?