Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix espressif serial over uart #5388

Merged
merged 1 commit into from
Sep 26, 2021
Merged

Fix espressif serial over uart #5388

merged 1 commit into from
Sep 26, 2021

Conversation

microdev1
Copy link
Collaborator

The common_hal_busio_uart_never_reset() function wasn't implemented in espressif port.
This caused serial over uart to not function properly as busio is reset at multiple occasions after serial_early_init().

@microdev1 microdev1 added bug espressif applies to multiple Espressif chips busio labels Sep 25, 2021
gamblor21
gamblor21 approved these changes Sep 25, 2021
View reviewed changes
Copy link
Member

@gamblor21 gamblor21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microdev1 microdev1 merged commit bd997dd into adafruit:main Sep 26, 2021
@microdev1 microdev1 deleted the serial-over-uart branch September 26, 2021 04:00
@microdev1 microdev1 mentioned this pull request Sep 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt left review comments

@gamblor21 gamblor21 gamblor21 approved these changes

Assignees
No one assigned
Labels
bug busio espressif applies to multiple Espressif chips
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@microdev1 @tannewt @gamblor21