-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Espressif: Use i2s peripheral for parallel LCD displays #5378
Conversation
.. most boards can't support non-sequential pins, so share the implementation of the error routine so we get an identical message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read through the code. Looks like more efficient and clearer use of the i2s peripheral (and esp’s library) to give more flexibility and also add 16 bit parallel LCD.
Good reuse of code for older _construct function.
Did not test on hardware.
The observed does not match the datasheet, so go with what was observed.
298ea57
to
a97e46b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on an UnexpectedMaker TinyS2 with the Adafruit 480x320 TFT breakout. Could only test non-sequential pins as I did not have 8 pins together, but no issues. Tried a few different display frequencies with no issues. Looked over the code and I saw no issues there.
hah, I forgot I hadn't acually tested non-consecutive pins 🤣 so thanks for that @gamblor21 |
This enables non-consecutive pins and higher effective clock rates. It successfully drives the 2.8" TFT LCD in parallel mode (but so did the previous code).
My testing board is an Espressif Kaluga and the code is