CI: Build docs dynamically #5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Sep 16, 2021
jepler
reviewed
Sep 16, 2021
- some refactoring - add doc build tools to search pattern - build all if trigger event is not a pr
|
I'll leave it to @tannewt to perform the final review. Thanks for addressing my specific low level concerns by changing the patterns, but I remain pessimistic about techniques like this being "right" and the initial round of changes are also causing me pain in my fork (#5359) and probably in others' forks, to the extent that actions is not useful anymore but just always errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build docs based on changes in certain directories and/or file types. Related to #4009.