Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear the buffer byte between ATB and FTB #5348

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Clear the buffer byte between ATB and FTB #5348

merged 1 commit into from
Sep 15, 2021

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Sep 14, 2021

This ensures it has a known start state. An unknown state risks it
looking like a tail block similar to the problem fixed by #5245.

Fixes #5305

@tannewt
Clear the buffer byte between ATB and FTB
e544909 
This ensures it has a known start state. An unknown state risks it
looking like a tail block similar to the problem fixed by micropython#5245.

Fixes micropython#5305
@tannewt tannewt added bug crash espressif applies to multiple Espressif chips labels Sep 14, 2021
@tannewt tannewt added this to the 7.0.0 milestone Sep 14, 2021
@tannewt tannewt requested review from anecdata and jepler September 14, 2021 23:26
dhalbert
dhalbert approved these changes Sep 14, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent debugging! Not tested; I'll leave that to @anecdata.

anecdata
anecdata reviewed Sep 15, 2021
View reviewed changes
Copy link
Member

@anecdata anecdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Cucumber with several files that consistently triggered the issue before. I have not been able to trigger the issue with this change in place.

Excellent debugging... seconded. Thanks, @tannewt!!

@dhalbert dhalbert mentioned this pull request Sep 15, 2021
Closed
@dhalbert dhalbert merged commit ad663cb into adafruit:main Sep 15, 2021
@jepler jepler mentioned this pull request Sep 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anecdata anecdata anecdata left review comments

@dhalbert dhalbert dhalbert approved these changes

@jepler jepler Awaiting requested review from jepler

Assignees
No one assigned
Labels
bug crash espressif applies to multiple Espressif chips
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Presence of boot.py in many cases will cause a boot loop on ESP32-S2 with TinyUF2 (rc, not beta)
3 participants
@tannewt @dhalbert @anecdata