Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename esp32s2 port to espressif #5342

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Sep 13, 2021

This is in preparation for ESP32-S3 support and potentially others.

Related to #4363

This is in preparation for ESP32-S3 support and potentially others.

Related to micropython#4363
@tannewt tannewt added refactoring espressif applies to multiple Espressif chips labels Sep 13, 2021
@tannewt tannewt requested a review from dhalbert September 13, 2021 23:46
Copy link
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannewt Thanks for looking into this. The CI failure is due to a few xtensa and esp32s2 still around.

I have pointed out a few here but there might be more:

xtensa-boards: ${{ steps.set-matrix.outputs.xtensa-boards }}

arch_to_boards = {"arm": [], "riscv": [], "xtensa": []}

circuitpython/.gitmodules

Lines 153 to 159 in 973a90f

[submodule "ports/esp32s2/esp-idf"]
path = ports/espressif/esp-idf
url = https://github.com/espressif/esp-idf.git
branch = release/v4.3
[submodule "ports/esp32s2/certificates/nina-fw"]
path = ports/espressif/certificates/nina-fw
url = https://github.com/adafruit/nina-fw.git

exclude: '^(tests/.*\.exp|tests/cmdline/.*|tests/.*/data/.*|ports/esp32s2/esp-idf-config/.*|ports/esp32s2/boards/.*/sdkconfig)'

Copy link
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@tannewt tannewt merged commit dfba2ee into adafruit:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
espressif applies to multiple Espressif chips refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants