-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the nRF builds with GCC 11.2 #5319
Conversation
See adafruit/Adafruit_nRF52_Bootloader#221 for background on the flag.
Are you using GCC 11.2 now? |
I'm starting to locally. The CI is 10.3 still. |
Good to know. Thanks. I'll give it a try and try creating a Raspberry pi build. |
Confirmed working here on a Feather nRF52840 Express. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
AH -- I see that 11.2 has not been released on the arm developers site yet https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-rm/downloads -- will we be officially staying at 10.3 until it is available there? Actually, Isn't CI (and the build guide still using 10.2.1 from https://developer.arm.com/-/media/Files/downloads/gnu-rm/10-2020q4/gcc-arm-none-eabi-10-2020-q4-major-x86_64-linux.tar.bz2?revision=ca0cbf9c-9de2-491c-ac48-898b5bbc0443&la=en&hash=68760A8AE66026BCF99F05AC017A6A50C6FD832A ? |
@jerryneedell GCC 11.2 has been released upstream and is already in Arch. The CI is indeed still 10.2.1: circuitpython/.github/workflows/build.yml Line 246 in 09859a6
|
We stick with the official ARM downloads for wide availability reasons: most people are not using Arch. We haven't yet upgraded to 10.3-2021.07, which ARM released in July, because the changes were not relevant to us, but probably will upgrade to that after 7.0.0 final. I would expect the ARM release to go to 11.x in December or January. Someone should report the 11.2 issue to Nordic in DevZone to give them a heads up. It could be me, but I don't have a good understanding of the issue yet. |
See adafruit/Adafruit_nRF52_Bootloader#221
for background on the flag.