Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the nRF builds with GCC 11.2 #5319

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Sep 8, 2021

See adafruit/Adafruit_nRF52_Bootloader#221
for background on the flag.

@jerryneedell
Copy link
Collaborator

Are you using GCC 11.2 now?

@tannewt
Copy link
Member Author

tannewt commented Sep 8, 2021

I'm starting to locally. The CI is 10.3 still.

@jerryneedell
Copy link
Collaborator

Good to know. Thanks. I'll give it a try and try creating a Raspberry pi build.

@rdoursenaud
Copy link

Confirmed working here on a Feather nRF52840 Express.
Lost USB connectivity without the patch.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@microdev1 microdev1 merged commit 09859a6 into adafruit:main Sep 9, 2021
@jerryneedell
Copy link
Collaborator

jerryneedell commented Sep 9, 2021

AH -- I see that 11.2 has not been released on the arm developers site yet https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-rm/downloads -- will we be officially staying at 10.3 until it is available there?

Actually, Isn't CI (and the build guide still using 10.2.1 from https://developer.arm.com/-/media/Files/downloads/gnu-rm/10-2020q4/gcc-arm-none-eabi-10-2020-q4-major-x86_64-linux.tar.bz2?revision=ca0cbf9c-9de2-491c-ac48-898b5bbc0443&la=en&hash=68760A8AE66026BCF99F05AC017A6A50C6FD832A ?

@rdoursenaud
Copy link

@jerryneedell GCC 11.2 has been released upstream and is already in Arch.

The CI is indeed still 10.2.1:

wget --no-verbose https://adafruit-circuit-python.s3.amazonaws.com/gcc-arm-none-eabi-10-2020-q4-major-x86_64-linux.tar.bz2

@dhalbert
Copy link
Collaborator

dhalbert commented Sep 9, 2021

We stick with the official ARM downloads for wide availability reasons: most people are not using Arch. We haven't yet upgraded to 10.3-2021.07, which ARM released in July, because the changes were not relevant to us, but probably will upgrade to that after 7.0.0 final. I would expect the ARM release to go to 11.x in December or January.

Someone should report the 11.2 issue to Nordic in DevZone to give them a heads up. It could be me, but I don't have a good understanding of the issue yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants