Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TinyUSB #5303

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Update TinyUSB #5303

merged 1 commit into from
Sep 7, 2021

Conversation

kamtom480
Copy link

The TinyUSB update fixes the USB MSC. The wrong variable was used in the if loop condition which caused the issue.

@hathach
Copy link
Member

hathach commented Sep 6, 2021

@kamtom480 hmm, I take this back, seem like i really meant to use total_bytes according to comment there. Please give me time to pull out Spresense to test.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge this yet, I am trying to find a better solution since this will cause the MSC compliance test suite to fail. For the detail explanation please checkout my comment here hathach/tinyusb#1070 (comment)

@hathach
Copy link
Member

hathach commented Sep 7, 2021

@kamtom480 I made an PR with special walkaround for cxd56 due to the reason that nuttx stack does not forward clear/set feature(endpoint) request to dcd. IMO, It is an better fix. Please check it out hathach/tinyusb#1075

@hathach
Copy link
Member

hathach commented Sep 7, 2021

@kamtom480 would you mind to bump up the tinyusb update for the hathach/tinyusb#1075

@kamtom480
Copy link
Author

The update that fixes MSC on Spresense. Thank you @hathach.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge when ci passes

@hathach hathach merged commit d29a12c into adafruit:main Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants