Split out paralleldisplay to its own module #5260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My interest in doing this right now is that for the ESP32-S2-HMI-DevKit-1, I may need to complicate the constructor to support non-consecutive pins; having this code disabled on the low-capacity boards that include displayio means less worry over code size increase. |
|
Thanks for grabbing this @tannewt ! |
tannewt
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. leaving a backwards-compatible alias in displayio.
This saves about 1kB flash on circuitplayground_express_displayio.
I tested this on a pyportal titano and the display still displays.
There seem to be no direct uses of displayio.ParallelDisplay within the bundle or learn, for whatever that's worth; just the couple of boards that have the displays built in.