add warmbit_bluepixel #5229
Merged
add warmbit_bluepixel #5229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We won't be able to merge this without a proper pid&vid, but I've approved the workflows to run for now so we can find out about any other problems. |
jepler
requested changes
Aug 26, 2021
There was a problem hiding this comment.
Thanks! CI passes with your new board, so I think all we need is for this PR to be updated with a properly allocate PID/VID. If your product is open source hardware, you can apply for one at pid.codes: https://pid.codes/howto/
tannewt
approved these changes
Aug 26, 2021
There was a problem hiding this comment.
This is the "proper" way to sublicense from Nordic: #5215 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is for my prototype board. use Nordic's VID and a random PID for now.