Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MP_REGISTER_MODULE with displayio, terminalio, and fontio #5221

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Use MP_REGISTER_MODULE with displayio, terminalio, and fontio #5221

merged 2 commits into from
Aug 25, 2021

Conversation

capellini
Copy link

Convert from using MICROPY_PORT_BUILTIN_MODULES_STRONG_LINKS to using MP_REGISTER_MODULE for displayio, terminalio, and fontio modules.

Related to #5183.

@capellini
Use MP_REGISTER_MODULE with displayio, terminalio, and fontio
17af5cd 
Convert from using MICROPY_PORT_BUILTIN_MODULES_STRONG_LINKS to using MP_REGISTER_MODULE for displayio, terminalio, and fontio modules.

Related to adafruit#5183.
@capellini
Copy link
Author

I tested on my pybadge loaded with a test project using the following procedure:

  • make clean && make
  • copy firmware.uf2 to pybadge
  • ensure sure project code works
  • refactor module and temporarily comment out MP_REGISTER_MODULE line
  • make clean && make
  • copy firmware.uf2 to pybadge
  • ImportError on pybadge
  • uncomment MP_REGISTER_MODULE line
  • make clean && make
  • copy firmware.uf2 to pybadge
  • ensure sure project code works

jepler
jepler previously approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, appreciate you diving in. While you're here, can you also correct a doc comment that is inaccurate? you already modified the line it's on.

py/circuitpy_mpconfig.h Outdated Show resolved Hide resolved
jepler
jepler approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@microdev1 microdev1 merged commit 8a89689 into adafruit:main Aug 25, 2021
@capellini capellini deleted the displayio-terminalio-fontio-mp_register_module branch August 25, 2021 12:32
@capellini
Copy link
Author

Thanks again!

You're most welcome! Happy to contribute and looking forward to contributing more.

@capellini capellini mentioned this pull request Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
enhancement refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@capellini @jepler @microdev1