Add Board bluemicro840 #5114
Merged
Add Board bluemicro840 #5114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We generally recommend a unique PID for CircuitPython but it's really up to you. I would pick the application pid 0x6161 over the bootloader one though. Our concern is that the PID is unique amongst CP boards. |
|
Thanks. I'll update the PID to the app one. |
|
It looks like the CI failures were due to the outages this morning. It wouldn't hurt to poke them again, but this should be safe to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding BlueMicro840 as board.
Used pre-existing/pre-approved VID/PID from openmoko.
https://github.com/openmoko/openmoko-usb-oui/blob/master/usb_product_ids.psv
What PID should be used? one specific for the board (bootloader) or a circuitpython-specific one?
Thanks