macropad rev B definion and fix for SH110x addressing #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…D1107 module we use is vertical orientation (confusing!) so row/col are NOT swapped. we will have to fix the SH1107 driver to match. this fix required for SH1106 (which uses the same page mode commands but ISNT rotated)
tannewt
reviewed
Jun 7, 2021
|
i will try rotation now (i also have to try the col offset thing) |
tannewt
requested changes
Jun 7, 2021
tannewt
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the SH1107 chipset is actually column not row mode (like the SSD1306!) BUT the SH1107 module we use on the featherwing is vertical orientation (confusing!). We should stick to the column mode addressing, but 'rotate' the SH1107 module.
we will have to fix the SH1107 driver to match
this fix required for SH1106 (which uses the same page mode commands but ISNT rotated). Tested on Macropad hardware