Add cp sapling rev b #4677
Merged
Add cp sapling rev b #4677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PID pending on Pid.Codes --> PID Codes PID PR |
|
This is failing on the Japanese language build. Not sure why it ends up being bigger than the on board flash.. will need to investigate this... |
|
you can add a |
Not sure why when I added that flag it was still failing. I ended up looking at the Qt Py M0 mpconfigboard.mk file and matching that and it's built without issue. not sure what the reasoning for that ends up being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a draft PR for the CP Sapling Rev B board. Will update to open once I can confirm all changes.