Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch devices.h to nvm.toml data #4481

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Switch devices.h to nvm.toml data #4481

merged 3 commits into from
Mar 25, 2021

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Mar 25, 2021

No description provided.

@tannewt tannewt requested a review from dhalbert March 25, 2021 00:13
dhalbert
dhalbert previously approved these changes Mar 25, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jepler
Copy link
Member

jepler commented Mar 25, 2021

This patch fixes some of the build problems but not all of them
0001-supervisor-Resolve-genhdr-devices.h-No-such-file-or-.patch.txt
The other type of problem I saw was in flash device naming changing slightly, it looks like fixing that may be more of a manual problem.

jepler
jepler approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a better fix than what I proposed.

@tannewt tannewt merged commit 5810461 into adafruit:main Mar 25, 2021
@dhalbert dhalbert mentioned this pull request Mar 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

@dhalbert dhalbert dhalbert left review comments

Assignees
No one assigned
Labels
tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tannewt @jepler @dhalbert