Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GCC @file to shorten linker command length #4480

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Mar 24, 2021

This hopefully fixes linking on Windows with cmd.exe

This hopefully fixes linking on Windows with cmd.exe
@ladyada
Copy link
Member

ladyada commented Mar 24, 2021

$ make BOARD=adafruit_feather_rp2040 -j 32
Use make V=1, make V=2 or set BUILD_VERBOSE similarly in your environment to increase build verbosity.
Traceback (most recent call last):
  File "gen_stage2.py", line 82, in <module>
    typer.run(main)
  File "C:/msys64/mingw64/lib/python3.8/site-packages/typer/main.py", line 859, in run
    app()
  File "C:/msys64/mingw64/lib/python3.8/site-packages/typer/main.py", line 214, in __call__
    return get_command(self)(*args, **kwargs)
  File "C:/msys64/mingw64/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "C:/msys64/mingw64/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "C:/msys64/mingw64/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "C:/msys64/mingw64/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "C:/msys64/mingw64/lib/python3.8/site-packages/typer/main.py", line 497, in wrapper
    return callback(**use_params)  # type: ignore
  File "gen_stage2.py", line 14, in main
    flashes = cascadetoml.filter_toml(pathlib.Path("../../data/nvm.toml"), skus)
  File "C:/msys64/mingw64/lib/python3.8/site-packages/cascadetoml.py", line 159, in filter_toml
    raise ValueError("Missing root .cascade.toml")
ValueError: Missing root .cascade.toml
make: *** [Makefile:271: build-adafruit_feather_rp2040/stage2.c] Error 1
make: *** Waiting for unfinished jobs....

@tannewt
Copy link
Member Author

tannewt commented Mar 24, 2021

What is your current path? I was hoping pathlib would handle the path stuff for windows.

Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay now builds!

@ladyada ladyada merged commit 7831be5 into adafruit:main Mar 25, 2021
@tannewt
Copy link
Member Author

tannewt commented Mar 25, 2021

(The build issue was that data/nvm.toml was empty and needed a git submodule update --init.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants