update logic for displayio.TileGrid's transform_xy #4464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an error in redrawing when using
transform_xy
withdisplayio.TileGrid
, referenced in issue #4450.The logic for
displayio_tilegrid_get_refresh_areas
did not consider the TileGrid'stransform_xy
value and the transform of dirty rectangles was not being performed.Here is the result with version
Adafruit CircuitPython 6.2.0-beta.4 on 2021-03-18; Adafruit PyPortal with samd51j20
:Here is the result with the updated code in this PR:
Here is my test code: