Fix reading 4-bit data #4454
Merged
Fix reading 4-bit data #4454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmatch98
previously approved these changes
Mar 21, 2021
deshipu
reviewed
Mar 21, 2021
shared-module/bitmaptools/__init__.c
Outdated
| @@ -464,7 +464,7 @@ void common_hal_bitmaptools_readinto(displayio_bitmap_t *self, pyb_file_obj_t *f | |||
| int byte_offset = x / 2; | |||
| int bit_offset = 4 * (reverse_pixels_in_element ? (1 - x % 2) : x % 2); | |||
|
|
|||
| value = (rowdata8[byte_offset] >> bit_offset) & 7; | |||
| value = (rowdata8[byte_offset] >> bit_offset) & 15; | |||
There was a problem hiding this comment.
Would be more obvious if written as 0x0f.
FoamyGuy
approved these changes
Mar 21, 2021
|
One action has been stuck in "upload artifacts" for 4 hours. Gonna merge without green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to adafruit/Adafruit_CircuitPython_ImageLoad#47
An incorrect mask was being used when extracting 4-bit data from a file.