-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adafruit funhouse #4439
Adafruit funhouse #4439
Conversation
draft for now; backlight issues |
I tested STM changes on a Feather STM32405, creating PWMOut's in the REPL to check the new error handling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotstars/LED/backlight/TFT works. i have more to test but this is good for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retroactive LGTM. The only thing we lose here is telling users that they might want to reshuffle certain initializations on STM32 so the dynamic timer allocation doesn't reserve timers on pins that require PWMOut. That was an STM32 specific issue, so I didn't want to abstract it to the shared bindings level. That only comes up if you're using PWMOut and PulseIO/Protomatter simultaniously though, so it's probably fine to leave debugging to the user.
Remind me the incentive for standardizing these exceptions again, does it have a benefit for displays? It's been a while since I touched it.
The reason to remove the exceptions and pass back status codes was that the on-board display initialization in There are a lot more cases for STM32 |
@dhalbert that's right, I remember that now. I thought I had a custom handler for that but I guess not. I guess we could make |
PWMOut
constructor return status values instead of throwing exceptions.PWMOut
may be created before exceptions can be thrown for backlight, etc. Changes inesp32s2
andstm
due to this (hence tagging @hierophect for a look).