Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Circuitpython port for Franzininho WIFI board with the ESP32-S2 wroom module #4347

Merged
merged 3 commits into from
Mar 8, 2021
Merged

Adding Circuitpython port for Franzininho WIFI board with the ESP32-S2 wroom module #4347

merged 3 commits into from
Mar 8, 2021

Conversation

FBSeletronica
Copy link

Hello all!

I'm adding a port for Franzininho WiFi Board with the ESP32-S2 module. I followed this guide to build the port.

Please let me know if I need to make some fixes or is everything ok.

Thanks

FBSeletronica
FBSeletronica commented Mar 6, 2021
View reviewed changes
Copy link
Author

@FBSeletronica FBSeletronica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the build.yml

tannewt
tannewt approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@tannewt tannewt merged commit 4fc6c7d into adafruit:main Mar 8, 2021
@FBSeletronica FBSeletronica deleted the franzininhoWIFI branch March 16, 2021 00:21
@FBSeletronica FBSeletronica restored the franzininhoWIFI branch March 16, 2021 00:21
@dhalbert dhalbert mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FBSeletronica @tannewt