Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rp2040 use of tud_disconnect #4327

Merged
merged 2 commits into from
Mar 4, 2021
Merged

fix rp2040 use of tud_disconnect #4327

merged 2 commits into from
Mar 4, 2021

Conversation

hathach
Copy link
Member

@hathach hathach commented Mar 4, 2021 •
edited
Loading

@hathach hathach changed the title fix rp2040 use fix rp2040 use of tud_disconnect Mar 4, 2021
@hathach hathach marked this pull request as ready for review March 4, 2021 14:03
@hathach hathach requested a review from jepler March 4, 2021 14:05
@dhalbert
Copy link
Collaborator

dhalbert commented Mar 4, 2021

The xtensa builds are using an old cache id. We can ignore their failures.

@hathach
Copy link
Member Author

hathach commented Mar 4, 2021

The xtensa builds are using an old cache id. We can ignore their failures.

I am doing rebase and will push force again.

@hathach hathach force-pushed the fix-4066-rp2040-hanged-tud_disconnect branch from afa5dc8 to c26120a Compare March 4, 2021 14:32
jepler
jepler approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing performed: Loaded a FW from this PR, ran storage.erase_filesystem(). It worked.

Thank you!

@dhalbert dhalbert merged commit 627c5f5 into adafruit:main Mar 4, 2021
@dhalbert
Copy link
Collaborator

dhalbert commented Mar 4, 2021

Let's ignore the build failures for now, though I'm surprised the rebase did not help.

@dhalbert dhalbert mentioned this pull request Mar 8, 2021
Closed
@hathach hathach deleted the fix-4066-rp2040-hanged-tud_disconnect branch March 10, 2021 06:05
@dhalbert dhalbert mentioned this pull request Mar 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RP2040 Pico - storage.erase_filesystem() does not reformat and erase
3 participants
@hathach @dhalbert @jepler