Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use self->members in displayio_group_set() #4322

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Mar 3, 2021

Fixes #4321. Tested by @kmatch98.

@dhalbert dhalbert requested a review from jepler March 3, 2021 22:38
@deshipu
Copy link

deshipu commented Mar 3, 2021

The fix works for me!

@dhalbert dhalbert requested a review from jerryneedell March 3, 2021 22:42
Copy link

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@dhalbert dhalbert requested review from kattni and removed request for jepler and jerryneedell March 3, 2021 22:48
@kmatch98
Copy link
Collaborator

kmatch98 commented Mar 3, 2021

I verified the code working with the test code shown in #4321 and with the “cow code” https://learn.adafruit.com/digital-nose-gas-sensor-milk-freshness-checker/code (both of which previously triggered the error).

@dhalbert dhalbert merged commit b71f3e1 into adafruit:main Mar 3, 2021
@dhalbert dhalbert deleted the group-list-member-fix branch March 3, 2021 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifying contents of a displayio.Group causes a hard crash
4 participants