Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spresense: return valid reference voltage #4310

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

kamtom480
Copy link

Return as reference voltage, 5V for pins A0, A1, A4 and A5. These pins are only available on the extension board. For pins A2 and A3 the reference voltage will differ depending on the board. For main board it is 0.7V and for extension board it is 5V. For this reason, I return 0 for these pins.

@dhalbert
Copy link
Collaborator

dhalbert commented Mar 2, 2021

Would you want to have multiple pin names for the pins that differ only via level shift on the main board and the extension board? The AnalogIn object would have to remember them since the internal pin numbers are the same. It would be a bit tricky. I am fine with the current scheme. I assume you will document this somewhere.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I am going to approve this for now and any pin changes can come later.

@dhalbert dhalbert merged commit 9f6ebf3 into adafruit:main Mar 2, 2021
@kamtom480
Copy link
Author

@dhalbert I will think how to handle it. This will be documented when we release our documentation for AnalogIn module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants