Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix two off by one errors #4278

Merged
merged 1 commit into from
Mar 1, 2021
Merged

fix two off by one errors #4278

merged 1 commit into from
Mar 1, 2021

Conversation

kmatch98
Copy link
Collaborator

Yikes! Found two off-by-one errors in my last commit on Bitmap.blit.

Lesson: Do way more testing prior to next PR request.

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix how many off by one errors? 😁

I didn't test it, but the changes make sense intuitively.

@jepler jepler merged commit 58de611 into adafruit:main Mar 1, 2021
@kmatch98
Copy link
Collaborator Author

kmatch98 commented Mar 1, 2021

Good question, whats the right function to use for counting off-by-one errors (can I pick the last one?)

  • 1+1+1+1
  • 2*1^2
  • 1^4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants