Update StateMachine.c #4276
Merged
Update StateMachine.c #4276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed woring to use max instead
dhalbert
reviewed
Mar 1, 2021
There was a problem hiding this comment.
@bergdahl Are you requesting this change to make both it and your translation shorter? I have been advocating use comparison operators like In-buffer elements must be <= 4 bytes long for brevity, but I don't know how easily that translates.
|
I don't see a problem expressing the error the same way you would express them in the language itself |
|
I didn't merge this during my stream. I only ran |
dhalbert
requested changes
Mar 2, 2021
dhalbert
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed wording to use "max" instead