Clear out PIOs and State Machines on RP2040 soft reset #4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from adafruit main
tannewt
requested changes
Feb 25, 2021
There was a problem hiding this comment.
Why is this in board? This code should already reset everything: https://github.com/adafruit/circuitpython/blob/main/ports/raspberrypi/common-hal/rp2pio/StateMachine.c#L94
|
Calling reset_rp2pio_statemachine() did not seem to clear the interrupt or
the
state machine program. When I used that and did the CTRL-C,CTRL-D sequence
I could see that the interrupt handler was still getting called.
…On Thu, Feb 25, 2021 at 4:18 PM Scott Shawcroft ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Why is this in board? This code should already reset everything:
https://github.com/adafruit/circuitpython/blob/main/ports/raspberrypi/common-hal/rp2pio/StateMachine.c#L94
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4265 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFNJKETGNKPNXNB3UPIELTLTA3ECNANCNFSM4YHA2RJQ>
.
|
|
Ok, I totally believe that. It seems to me that reset_rp2pio_statemachine should turn off interrupts as well instead of having a separate way to reset things. |
tannewt
requested changes
Mar 2, 2021
shared-module/board/__init__.c
Outdated
| @@ -179,4 +183,7 @@ void reset_board_busses(void) { | |||
| #if BOARD_UART | |||
| MP_STATE_VM(shared_uart_bus) = NULL; | |||
| #endif | |||
| #if CIRCUITPY_RP2PIO | |||
| reset_rp2pio_statemachine(); | |||
There was a problem hiding this comment.
I don't think we need this anymore because port_reset should call reset_rp2pio_statemachine. rp2pio is meant to be port-specific so it shouldn't influence any code outside of ports/raspberrypi
There was a problem hiding this comment.
Removed it and still tested OK. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code to make sure PIOs and state machines are cleared out on a soft reset.