Rp2040 countio #4254
Merged
Rp2040 countio #4254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dddb4e5 to
379f454
Compare
tannewt
requested changes
Feb 24, 2021
tannewt
requested changes
Mar 2, 2021
There was a problem hiding this comment.
Thanks for the update! It looks good. However, I thought of another case that probably needs to be handled. We likely need to set one of the globals from PWMOut so that it doesn't allocate to the channel A pin at the same time. Could you try making a countio and then making a PWMOut on the other pin? It should error. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding countio to RP2040. This build uses the PWM IRQ that does not seem in use in the PWM module. If the PWM module started to use it there could be a conflict.