set SUPEROPT_VM = 0 on most non-Express SAMD21 boards #4248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had many ad-hoc build-shrink settings for builds that were too big, most of which are SAMD21 boards with no external flash. This set of changes sets
SUPEROPT_VM = 0on most of these boards, except for those that already have several modules turned off to make space. It removes the translation-specific shrinks that increase build time and make performance vary by language.SUPEROPT_VM = 0is reported to decrease performance by about 20%. This is somewhat regrettable, but there were a number of boards that already had this setting (e.g. Trinket M0). Others escaped it only by the skin of their teeth. The setting saves about 1060 bytes.If this is merged, we can re-run #4245 and expect it to pass.
Tagging for interest @kamtom480 and @hathach.