Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Unexpected Maker TinyS2 board definition #4244

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Added Unexpected Maker TinyS2 board definition #4244

merged 1 commit into from
Feb 23, 2021

Conversation

UnexpectedMaker
Copy link

Added first pass board definitions for my new TinyS2 board

@tannewt
Copy link
Member

tannewt commented Feb 23, 2021

From the CI:

Run python3 -u ci_new_boards_check.py
Boards missing in .github/workflows/build.yml:
unexpectedmaker_tinys2

You may want to install pre-commit as well. It'll auto-fix the issues it finds. https://pre-commit.com/#installation

@UnexpectedMaker
Copy link
Author

From the CI:

Run python3 -u ci_new_boards_check.py
Boards missing in .github/workflows/build.yml:
unexpectedmaker_tinys2

You may want to install pre-commit as well. It'll auto-fix the issues it finds. https://pre-commit.com/#installation

Ok, I'll have a read through that doc and try to find some time to get it all installed and setup later this week, thanks :)

@UnexpectedMaker
Copy link
Author

@tannewt I ran python3 -u ci_new_boards_check.py (after installing pyjama and sh) and it did it's thing, and I can see tinys2 in the build.yaml file, but nothing new to commit. How do I get this up to git to make the CI happy ?

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just a network failure we can ignore. Will merge now. Thanks!

@tannewt tannewt merged commit e41137c into adafruit:main Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants