Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to ulab 1.7.5 #4229

Merged
merged 1 commit into from
Feb 20, 2021
Merged

update to ulab 1.7.5 #4229

merged 1 commit into from
Feb 20, 2021

Conversation

jepler
Copy link
Member

@jepler jepler commented Feb 20, 2021

This fixes several problems:

  • memoryview(ndarray) & internal uses of ndarrays with mp_get_buffer and mp_get_buffer_raise no longer hardfault
  • ones(), full(), zeros() and eye() with dtype=bool gave wrong results
  • linalg.dot() could give incorrect results

Thanks to @v923z for making these fixes in the "legacy" branch of ulab, which is used by CircuitPython!

@jepler jepler requested a review from dhalbert February 20, 2021 18:14
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @jepler and @v923z! This fixes #4207, which was crashing due to the ulab issue v923z/micropython-ulab#328, and was fixed by v923z/micropython-ulab#329.

@dhalbert dhalbert merged commit 2074244 into adafruit:main Feb 20, 2021
@jepler jepler deleted the update-ulab-175 branch November 3, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants