Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32S2: pin_number_is_free should not check never_reset tables #4205

Merged
merged 1 commit into from
Feb 15, 2021
Merged

ESP32S2: pin_number_is_free should not check never_reset tables #4205

merged 1 commit into from
Feb 15, 2021

Conversation

hierophect
Copy link
Collaborator

Originally implemented in #3930
Reverted in #4012 without separating out this bugfix
May be responsible for #4142

@hierophect hierophect requested a review from anecdata February 15, 2021 15:39
Copy link
Member

@anecdata anecdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me functionally for 4142. I haven't looked into how is_free or never_reset work.:

Adafruit CircuitPython 6.2.0-beta.2-16-gbc6db350e on 2021-02-15; Adafruit MagTag with ESP32S2
>>> import board
>>> spi = board.SPI()
>>> spi.frequency
250000

@hierophect
Copy link
Collaborator Author

@dhalbert since @anecdata has tested, I'm just pinging you for structural go-ahead.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dhalbert dhalbert merged commit 5ccbb0b into adafruit:main Feb 15, 2021
@hierophect hierophect deleted the esp32s2-fix-pinfree branch February 15, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants