-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create tests/_manual, add Socket tests #4187
Conversation
Why is there an underscore in the name? |
I thought it might be appropriate to distinguish them from the Micropython battery of tests that are run automatically by |
If anything we could do Note, I added |
That sounds good to me, since there's already a convention there. I'll change this PR to merge the two under that name. |
Ok, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This PR adds a new manual tests folder for scripts that are primarily useful for testing core modules (ie, that do not use libraries and focus on raw API access to a single module). It also adds three tests: Host, Client, and NTP access tests for the Socket module. Future additions to this testing folder should be sorted by module name, matching shared-bindings and common-hal.