Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests/_manual, add Socket tests #4187

Merged
merged 4 commits into from
Feb 20, 2021
Merged

Create tests/_manual, add Socket tests #4187

merged 4 commits into from
Feb 20, 2021

Conversation

hierophect
Copy link
Collaborator

This PR adds a new manual tests folder for scripts that are primarily useful for testing core modules (ie, that do not use libraries and focus on raw API access to a single module). It also adds three tests: Host, Client, and NTP access tests for the Socket module. Future additions to this testing folder should be sorted by module name, matching shared-bindings and common-hal.

@tannewt
Copy link
Member

tannewt commented Feb 12, 2021

Why is there an underscore in the name?

@hierophect
Copy link
Collaborator Author

Why is there an underscore in the name?

I thought it might be appropriate to distinguish them from the Micropython battery of tests that are run automatically by run-tests. The rest of the tests in that folder are very uniform in style and purpose, and these are different enough that I thought it'd be worth prefixing them.

@tannewt
Copy link
Member

tannewt commented Feb 16, 2021

Why is there an underscore in the name?

I thought it might be appropriate to distinguish them from the Micropython battery of tests that are run automatically by run-tests. The rest of the tests in that folder are very uniform in style and purpose, and these are different enough that I thought it'd be worth prefixing them.

If anything we could do circuitpy-manual to mimic what we do in py.

Note, I added manual with my audiopwm changes that were merged in already.

@hierophect
Copy link
Collaborator Author

If anything we could do circuitpy-manual to mimic what we do in py.

That sounds good to me, since there's already a convention there. I'll change this PR to merge the two under that name.

@tannewt
Copy link
Member

tannewt commented Feb 17, 2021

If anything we could do circuitpy-manual to mimic what we do in py.

That sounds good to me, since there's already a convention there. I'll change this PR to merge the two under that name.

Ok, thanks!

@hierophect hierophect requested a review from tannewt February 17, 2021 16:42
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 5d15493 into adafruit:main Feb 20, 2021
@hierophect hierophect deleted the manual-tests branch February 22, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants