Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design Guide Update - Exception and asserts #4185

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Design Guide Update - Exception and asserts #4185

merged 1 commit into from
Feb 12, 2021

Conversation

caternuson
Copy link

As discussed here:
https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx/pulls#issuecomment-663080712

Updates Design Guide with recommendation on using Exceptions and asserts.

@caternuson caternuson mentioned this pull request Feb 11, 2021
Closed
ladyada
ladyada approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tannewt
tannewt approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for expanding the design guide! It's really good to keep it up to date.

@tannewt tannewt merged commit 766e79a into adafruit:main Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caternuson @tannewt @ladyada