Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RP2040: Support for NVM #4177

Merged
merged 5 commits into from
Mar 2, 2021
Merged

RP2040: Support for NVM #4177

merged 5 commits into from
Mar 2, 2021

Conversation

microdev1
Copy link
Collaborator

No description provided.

@tannewt tannewt self-requested a review February 11, 2021 20:21
@tannewt tannewt added the rp2040 Raspberry Pi RP2040 label Feb 11, 2021
tannewt
tannewt requested changes Feb 11, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also modify the length of FLASH_FIRMWARE in link.ld so it doesn't accidentally overwrite things. Thanks for adding this!

ports/raspberrypi/common-hal/nvm/ByteArray.c Outdated Show resolved Hide resolved
@microdev1
implement suggested changes
527b11f 
- update FLASH_FIRMWARE length
- use linker script define value
@microdev1
Merge branch 'main' into nvm-rp
f2d7a5f
@microdev1 microdev1 requested a review from tannewt February 12, 2021 13:08
tannewt
tannewt requested changes Feb 12, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on size. Thanks for updating the linker script!

ports/raspberrypi/common-hal/nvm/ByteArray.c Show resolved Hide resolved
tannewt
tannewt requested changes Feb 20, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I was confused. I've suggested a way to clarify it.

ports/raspberrypi/common-hal/nvm/ByteArray.c Show resolved Hide resolved
ports/raspberrypi/common-hal/nvm/ByteArray.c Outdated Show resolved Hide resolved
@microdev1 microdev1 requested a review from tannewt March 2, 2021 09:11
tannewt
tannewt approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@tannewt tannewt merged commit ce70b95 into adafruit:main Mar 2, 2021
@microdev1 microdev1 deleted the nvm-rp branch March 3, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
rp2040 Raspberry Pi RP2040
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@microdev1 @tannewt