Neopixel rp2040 fix #4149
Closed
Neopixel rp2040 fix #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gamblor21 This PR appears to add "parallel bss" support, I don't see where it addresses #4135. Is taht included somewhere? |
|
I somehow messed up my PR... the last commit fixes the issue (run background tasks...). I have to see how to remove the other commits ugh. |
|
Ah -- now I see it -- good luck! |
b1f96e1 to
1b62921
Compare
|
I tried this on a Pico, unfortunately it is not resolving the problems -- still getting some odd behavior especially on the single writes. |
|
Closing in favor of #4155. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #4135 to run background tasks before starting a non-dma transfer of data. Non-dma transfers are used when writing less then 32 bytes (which equates to 10 RGB neopixles). The fact a background task may not need to run explains why it was also further unpredictable.
Running background tasks at all during a loop writing the 32 or less bytes could cause a timing issue so discussion should take place on if that should even take place.