Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket: Connect accepted sockets #4139

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Socket: Connect accepted sockets #4139

merged 1 commit into from
Feb 8, 2021

Conversation

hierophect
Copy link
Collaborator

This PR fixes an issue where sockets created by accept() were not given the sock->connected = true internal parameter, and thus caused send() to fail when used in a server context. Found while creating a new suite of socket tests.

@hierophect hierophect added network espressif applies to multiple Espressif chips labels Feb 5, 2021
dhalbert
dhalbert approved these changes Feb 8, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert dhalbert merged commit f171660 into adafruit:main Feb 8, 2021
@hierophect hierophect deleted the socket-accept-conn branch February 9, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@tannewt tannewt Awaiting requested review from tannewt

Assignees
No one assigned
Labels
espressif applies to multiple Espressif chips network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hierophect @dhalbert