Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add A3 pin to Raspberry Pi Pico #4125

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Add A3 pin to Raspberry Pi Pico #4125

merged 2 commits into from
Feb 5, 2021

Conversation

xorbit
Copy link

@xorbit xorbit commented Feb 4, 2021

We want to be able to use this to measure VSYS.

@xorbit
Add A3 pin to Raspberry Pi Pico
d357a05 
We want to be able to use this to measure VSYS.
tannewt
tannewt requested changes Feb 4, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! That's what it's used for! Do you have any reason to call it A3? We commonly have a VOLTAGE_MONITOR pin name on other boards. That'd make it clearer that the pin isn't broken out.

@tannewt tannewt added the rp2040 Raspberry Pi RP2040 label Feb 4, 2021
@xorbit
Copy link
Author

xorbit commented Feb 4, 2021

How about having both A3 and VOLTAGE_MONITOR names available? The RPi Pico docs seem to call it A3 so I would think it would be best to have this name available for the people coming from that side but VOLTAGE_MONITOR for the people who come from the Adafruit / CircuitPython side.

@dhalbert
Copy link
Collaborator

dhalbert commented Feb 5, 2021

How about having both A3 and VOLTAGE_MONITOR names available? The RPi Pico docs seem to call it A3 so I would think it would be best to have this name available for the people coming from that side but VOLTAGE_MONITOR for the people who come from the Adafruit / CircuitPython side.

That's fine with me. Could you push a new commit to add VOLTAGE_MONITOR?

tannewt
tannewt approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit e7438c4 into adafruit:main Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
rp2040 Raspberry Pi RP2040
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xorbit @dhalbert @tannewt