Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarified i2 c init error msg take 2 #4118

Merged
merged 3 commits into from
Feb 3, 2021
Merged

Clarified i2 c init error msg take 2 #4118

merged 3 commits into from
Feb 3, 2021

Conversation

BiffoBear
Copy link

A fresh attempt at clarifying the I2C init error message, after I ran git train --wreck on the last one.

ajs256
ajs256 previously approved these changes Feb 3, 2021
View reviewed changes
Copy link

@ajs256 ajs256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me (a grammar nerd), but some more experienced eyes should check first.

@ajs256
Copy link

ajs256 commented Feb 3, 2021

Looks like the CI fail was for Trinket M0 in ja, that might need some shrinking.

@BiffoBear
Copy link
Author

Looks like the CI fail was for Trinket M0 in ja, that might need some shrinking.

Thanks, this caused mayhem in my last attempt. @dhalbert has a fix, so I'll wait for his advice. I appreciate you taking the time to review my PR.

@dhalbert
Copy link
Collaborator

dhalbert commented Feb 3, 2021

Just replace boards/trinket_m0/mpconfigboard.mk with this version:
https://github.com/adafruit/circuitpython/blob/595356d7fdd132c41c42a1441d41ade999b8f7b4/ports/atmel-samd/boards/trinket_m0/mpconfigboard.mk

@BiffoBear
Copy link
Author

Just replace boards/trinket_m0/mpconfigboard.mk with this version:
https://github.com/adafruit/circuitpython/blob/595356d7fdd132c41c42a1441d41ade999b8f7b4/ports/atmel-samd/boards/trinket_m0/mpconfigboard.mk

OK that's done. Thank you for your help and patience.

dhalbert
dhalbert approved these changes Feb 3, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience as well, and for the original idea!

@dhalbert dhalbert merged commit cd616f6 into adafruit:main Feb 3, 2021
@BiffoBear BiffoBear deleted the Clarified-I2C-init-error-msg-take-2 branch February 3, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@ajs256 ajs256 ajs256 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BiffoBear @ajs256 @dhalbert