Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed for boards without longint #4112

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

gamblor21
Copy link
Member

@gamblor21 gamblor21 commented Feb 2, 2021

Fix to avoid using any long int for builds that have it disabled. The end keyword is now also omitted if the default value of INT_MAX is given to avoid converting it to a smaller value.

Tested on a Feather M4 Express with long int disabled and a BME280.

For issue #4109

Copy link
Collaborator

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on hallowing_m0_express by running lis3dh_simpletest (as in #4109)-- worked fine.
Also ran on qtpy_m0_haxpress -- still works!

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@tannewt
Copy link
Member

tannewt commented Feb 2, 2021

Single CI failure was a network error. Merging anyway.

@tannewt tannewt merged commit db7a962 into adafruit:main Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants