-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protomatter: Update to version that supports tiling #4068
Conversation
* Introduce explicit serpentine: bool argument instead of using negative numbers (thanks, ghost of @tannewt sitting on one shoulder) * Fix several calculations of height Testing performed (matrixportal): * set up a serpentine 64x64 virtual display with 2 64x32 tiles * tried all 4 rotations * looked at output of REPL
This was hard to write, so let's have it written in 2 places instead of 4.
@PaintYourDragon if you care to do testing: matrixportal-tiled.zip Code for creating a 64x64 display from two 32x64 displays in serpentine arrangement:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for the update!
8bd9b90
to
189ec2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested using two 32x64 matrices with the Matrix portal. Worked fine in serpentine True and False. Reviewed the files and looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🐍 🐍 🐍 🐍 🐍 |
Update to a version of Protomatter that supports tiling. This requires adafruit/Adafruit_Protomatter#32 be merged upstream.
Testing performed: None yet, just that the matrixfeather firmware builds.