Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RP2040: add GP15 #4063

Merged
merged 3 commits into from
Jan 26, 2021
Merged

RP2040: add GP15 #4063

merged 3 commits into from
Jan 26, 2021

Conversation

dhalbert
Copy link
Collaborator

Fixes #4034.

It looks like GP15 should be available after USB reset for general use.

@dhalbert dhalbert requested review from tannewt and ladyada January 25, 2021 16:03
ladyada
ladyada previously approved these changes Jan 25, 2021
View reviewed changes
tannewt
tannewt requested changes Jan 25, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to remove the pin in use bit too. /me looks

@tannewt
Copy link
Member

tannewt commented Jan 25, 2021

https://github.com/adafruit/circuitpython/blob/main/ports/raspberrypi/common-hal/microcontroller/Pin.c#L145-L150

dhalbert
dhalbert commented Jan 25, 2021
View reviewed changes
Copy link
Collaborator Author

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannewt See my "review" comments for question re two places where top pin is assume to be 32 instead of 30.

ports/raspberrypi/common-hal/microcontroller/Pin.c Outdated Show resolved Hide resolved
@dhalbert dhalbert requested a review from tannewt January 25, 2021 21:09
@dhalbert
Copy link
Collaborator Author

Thanks - I grepped for GP15, but not a bare 15.

@tannewt tannewt mentioned this pull request Jan 25, 2021
Closed
tannewt
tannewt previously approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt mentioned this pull request Jan 25, 2021
Closed
10 tasks
@dhalbert dhalbert requested review from tannewt and ladyada January 26, 2021 03:34
jepler
jepler approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, no testing performed.

@dhalbert dhalbert merged commit a9227e1 into adafruit:main Jan 26, 2021
@dhalbert dhalbert deleted the rp2040-gp15 branch January 26, 2021 20:41
@danpeirce danpeirce mentioned this pull request Feb 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

@tannewt tannewt Awaiting requested review from tannewt

@ladyada ladyada Awaiting requested review from ladyada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing GP15 in board module for Raspberry Pi Pico
4 participants
@dhalbert @tannewt @ladyada @jepler