-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIRCUITPY_* switches for JSON, RE, etc. Doc cleanup #4060
Conversation
33448bf
to
34d63de
Compare
Confirmed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about moving them to shared-bindings properly? That'd mean the docs use stubs and would be in circuitpython-stubs too.
I want to do that in the long run:, #1899, #1900, #1901, and will come back to that. I started to do it a while ago but it turned out to be more than a half-day or one-day project. If I remember right there was considerable refactoring involved to separate out the API from the implementation. I think I have a branch stashed away. This is a good intermediate step and fixes the sad state of the doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does what I thought it would have, plus some things I would have forgotten. I did spot one maybe-error, though. Give it a double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@dhalbert unfortunately this is failing a build due to lack of space --
I hadn't seen french be the biggest translation before now. I think there are some modules that can be excluded from simmel to get it to fit again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it builds, merge it! That should give plenty of headroom.
Fixes #4056
Fixes #1911.
CIRCUITPY_BINASCII
,CIRCUITPY_ERRNO
,CIRCUITPY_JSON
,CIRCUITPY_RE
, switches to make these non-shared-binding
modules be switchable like other features.json
,re
, and other forrmeru*
MicroPython native modules up to date .