Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIRCUITPY_* switches for JSON, RE, etc. Doc cleanup #4060

Merged
merged 8 commits into from
Jan 26, 2021

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Jan 25, 2021

Fixes #4056
Fixes #1911.

  • Add CIRCUITPY_BINASCII, CIRCUITPY_ERRNO, CIRCUITPY_JSON, CIRCUITPY_RE, switches to make these non-shared-binding modules be switchable like other features.
  • Bring documentation about json, re, and other forrmer u* MicroPython native modules up to date .
  • Make "Support Matrix" heading clearer.

@dhalbert dhalbert force-pushed the regularize-extmod-modules branch from 33448bf to 34d63de Compare January 25, 2021 14:29
@dhalbert dhalbert marked this pull request as ready for review January 25, 2021 16:58
@dhalbert dhalbert requested review from jepler and tannewt January 25, 2021 17:04
@dhalbert
Copy link
Collaborator Author

Confirmed that raspberrypi and esp32-s2 builds still have json, etc. included.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about moving them to shared-bindings properly? That'd mean the docs use stubs and would be in circuitpython-stubs too.

@dhalbert
Copy link
Collaborator Author

dhalbert commented Jan 25, 2021

What do you think about moving them to shared-bindings properly? That'd mean the docs use stubs and would be in circuitpython-stubs too.

I want to do that in the long run:, #1899, #1900, #1901, and will come back to that. I started to do it a while ago but it turned out to be more than a half-day or one-day project. If I remember right there was considerable refactoring involved to separate out the API from the implementation. I think I have a branch stashed away. This is a good intermediate step and fixes the sad state of the doc.

@dhalbert dhalbert requested a review from tannewt January 25, 2021 23:51
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does what I thought it would have, plus some things I would have forgotten. I did spot one maybe-error, though. Give it a double check.

py/circuitpy_mpconfig.h Outdated Show resolved Hide resolved
jepler
jepler previously approved these changes Jan 26, 2021
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jepler
Copy link
Member

jepler commented Jan 26, 2021

@dhalbert unfortunately this is failing a build due to lack of space --

Build simmel for fr took 25.47s and failed
make: Entering directory '/home/runner/work/circuitpython/circuitpython/ports/nrf'
Use make V=1, make V=2 or set BUILD_VERBOSE similarly in your environment to increase build verbosity.

245912 bytes used, -152 bytes free in flash firmware space out of 245760 bytes (240.0kB).
41592 bytes used, 89480 bytes free in ram for stack and heap out of 131072 bytes (128.0kB).

I hadn't seen french be the biggest translation before now. I think there are some modules that can be excluded from simmel to get it to fit again.

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it builds, merge it! That should give plenty of headroom.

@dhalbert dhalbert merged commit 13812a7 into adafruit:main Jan 26, 2021
@dhalbert dhalbert deleted the regularize-extmod-modules branch January 26, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants