Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DigitalInOut.pull on RP2040 #4052

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Fix DigitalInOut.pull on RP2040 #4052

merged 2 commits into from
Jan 23, 2021

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jan 23, 2021

It used to always return None.

Fixes #4035

@tannewt
Fix DigitalInOut.pull on RP2040
de6b05a 
It used to always return None.

Fixes micropython#4035
@tannewt tannewt added bug rp2040 Raspberry Pi RP2040 labels Jan 23, 2021
@tannewt tannewt added this to the 6.x.x - Bug Fixes milestone Jan 23, 2021
dhalbert
dhalbert previously approved these changes Jan 23, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

dhalbert
dhalbert approved these changes Jan 23, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Shrank a couple of overflowing builds.

@dhalbert dhalbert merged commit 97f5d21 into adafruit:main Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
bug rp2040 Raspberry Pi RP2040
Projects
None yet
Milestone
6.x.x - Bug Fixes
Development

Successfully merging this pull request may close these issues.

Fix DigitalInOut.pull
2 participants
@tannewt @dhalbert